Merge pull request #38 from github/td/lowercase-code-block-hotkey

Change code block hotkey from E -> e
github · Mar 23, 2021 · 40b95c5 · 40b95c5
2 parents e9a2547 + f34eb14
commit 40b95c5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -184,7 +184,7 @@ class MarkdownCodeButtonElement extends MarkdownButtonElement {
 
   connectedCallback() {
     super.connectedCallback()
-    this.setAttribute('hotkey', 'E')
+    this.setAttribute('hotkey', 'e')
   }
 }
 

diff --git a/test/test.js b/test/test.js
@@ -205,13 +205,6 @@ describe('markdown-toolbar-element', function () {
         pressHotkey('B') // capital `B` instead of lowercase `b`
         assert.equal('The |quick| brown fox jumps over the lazy dog', visualValue())
       })
-
-      it('does not codeblock selected text when using the lowercased hotkey', function () {
-        focus()
-        setVisualValue('The |quick| brown fox jumps over the lazy dog')
-        pressHotkey('e') // lowercase `e` instead of uppercase `E`
-        assert.equal('The |quick| brown fox jumps over the lazy dog', visualValue())
-      })
     })
 
     describe('bold', function () {
@@ -629,7 +622,7 @@ describe('markdown-toolbar-element', function () {
       it('surrounds a line with backticks via hotkey', function () {
         focus()
         setVisualValue("|puts 'Hello, world!'|")
-        pressHotkey('E')
+        pressHotkey('e')
         assert.equal("`|puts 'Hello, world!'|`", visualValue())
       })