Convert remaining TSG and reenable old tests #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include edge debug information in visualization
Display stacks for each time a path crosses a node
…nts do not have to go through a seemingly fallible lookup themselves
Ensure special files are also indexed
Add flag to set max test runtime and limit CI test runner by default
…o ControlledOption
Add `fully_qualified_name` field to `SourceInfo`
Add `visualize` command
Use transaction mechanism instead of explicit BEGIN/COMMIT
BekaValentine
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR. This completes the conversion from the stack graph rules in the old DSL to the new DSL. All tests (old and new) now succeed.
Details:
Converts anything that wasn't in the new TSG yet.
Reenables old tests. A few test expectations had to be changed in 2c16b0a, 9e04e60, ff5fce9, 297feec. I think those adjustments make sense, but it would be good to review those. All the old tests pass, as well as the new ones 🎉
Reverts the use of
GUARD:MEMBERto.in dc7f042. This seemed a change that was in-progress. Reverting it was the easiest way for me to test the rest, but I have no objections to that change in itself.Adds support for
definiens_spanandsyntax_typeattributes in f8009e1.Merges in the latest changes from
main.Notes:
Instead of figuring out which syntax nodes have which (graph node) scoped variables, I've simply defined all possible (graph node) scoped variables on all nodes. A tree-sitter patch will make sure that the unused nodes do not end up in the stack graph.
There are some warnings about
definiens_spanandsyntax_typebeing used on non-definition nodes. It looks like there are some cases where@name.popis not turned into a definition. I haven't had time to dive into that, but it might suggest a coverage problem.