Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort debug attributes in visualization #297

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Conversation

hendrikvanantwerpen
Copy link
Collaborator

Debug attributes in the visualization do not appear in a fixed order. This PR makes sure they are sorted by attribute name and displayed in a stable order.

(This OR also removes a left-over HTML file.)

@github-actions
Copy link

Performance Summary

Comparing base acb0fab with head e721b3a on microsoft/TypeScript@v4.9.5. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    GB
1.201^            #                                                           
     |            #                                                           
     |            #                                                           
     |            #                                                           
     |           @#                  :                                   :    
     |           @#        :         :                                   :    
     |           @#        :         :                                : ::    
     |           @#        : ::      :     :                         @: ::    
     |           @#       :: :      :: ::  :          :              @: ::    
     |     :::   @#       :: :      :: : :::         ::    ::        @: ::    
     |     ::    @#: :: :::: :   :  :: : : : ::      ::    :    :: : @:::: :  
     |     :: @  @# ::: ::::::   ::::: : : : ::  ::  :: : :: :  :@ ::@::::@:  
   0 +----------------------------------------------------------------------->Gi
     0                                                                   190.6
After
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- test/src/compiler
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    MB
873.4^                                #                                       
     |                                #                                       
     |                                #                                       
     |                                #                                       
     |            @                   #                               : :     
     |            @          ::      :#                               : :     
     |           :@       :  :       :#              :                : :     
     |        @  :@     : :  :       :#              :                :::     
     |        @  :@     : :: :       :#             ::     :         @:::     
     |      ::@  :@   ::: :: :   @   :# : :    ::   ::    ::     :   @:::     
     |      : @  :@:::::: :: :   @: ::# : ::   :    :: :@:::     : : @::::: : 
     |      : @:::@:::::: :: :  :@::::# ::::   : :  ::::@::::::@:: ::@:::::@::
   0 +----------------------------------------------------------------------->Gi
     0                                                                   172.1

@BekaValentine BekaValentine merged commit 5cc5a7e into main Jul 20, 2023
8 checks passed
@BekaValentine BekaValentine deleted the sort-debug-attrs branch July 20, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants