Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new data for base branch perf job too #304

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

hendrikvanantwerpen
Copy link
Collaborator

Now that #303 is merged, we can change base branch CI job to use local data as well. (THis wasn't there before #303, so only the head branch used it in that PR.)

@hendrikvanantwerpen hendrikvanantwerpen requested a review from a team as a code owner July 28, 2023 18:24
@hendrikvanantwerpen hendrikvanantwerpen self-assigned this Jul 28, 2023
@github-actions
Copy link

Performance Summary

Comparing base 342d987 with head ffcbf40 on typescript_benchmark benchmark. For details see workflow artifacts. Note that performance is tested on the last commits with changes in stack-graphs, not on every commit.

Before
--------------------------------------------------------------------------------
Command:            base/target/release/tree-sitter-stack-graphs-typescript index -D base.sqlite --max-file-time=30 --hide-error-details -- base/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 base-perf-results/perf.out
--------------------------------------------------------------------------------


    MB
715.8^                                                                  #     
     |                                              @                   #     
     |                          @                  @@                  :#     
     |                          @                 :@@                 ::#:    
     |                          @                 :@@                 ::#:    
     |                        ::@                ::@@  :::            ::#:    
     |                  : :  :: @                ::@@  ::           ::::#: :: 
     |                 @: ::::: @       :        ::@@::::           : ::#:::: 
     |                 @:::: :: @      ::       @::@@: ::           : ::#:::: 
     |                 @:::: :: @  :::::::      @::@@: ::          :: ::#:::: 
     |                @@:::: :: @  ::: :::::   :@::@@: ::          :: ::#:::: 
     |                @@:::: :: @  ::: :::: :: :@::@@: :: :::::::: :: ::#:::: 
   0 +----------------------------------------------------------------------->Gi
     0                                                                   57.22
After
--------------------------------------------------------------------------------
Command:            head/target/release/tree-sitter-stack-graphs-typescript index -D head.sqlite --max-file-time=30 --hide-error-details -- head/data/typescript_benchmark
Massif arguments:   --massif-out-file=perf.out
ms_print arguments: --x=72 --y=12 head-perf-results/perf.out
--------------------------------------------------------------------------------


    MB
715.8^                                                                     ## 
     |                                                                     #  
     |                             @@                    @@                #  
     |                             @                    :@                :#  
     |                             @                    :@                :#  
     |                     :     ::@                  :::@              :::#  
     |                     ::: ::: @                  : :@              : :#  
     |                     :: :: : @        ::       :: :@ :            : :#  
     |                     :: :: : @       ::        :: :@ :           :: :#  
     |                   @@:: :: : @  :::::::     @  :: :@ :           :: :#  
     |                   @ :: :: : @  :: : :: @   @  :: :@ :     ::: :::: :# :
     |                   @ :: :: : @ ::: : :: @:::@  :: :@ ::::::: : : :: :# :
   0 +----------------------------------------------------------------------->Gi
     0                                                                   51.37

@hendrikvanantwerpen hendrikvanantwerpen merged commit aaec4ec into main Jul 28, 2023
8 of 9 checks passed
@hendrikvanantwerpen hendrikvanantwerpen deleted the update-perf-base branch July 28, 2023 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants