Enable similar path detection by default #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar path detection prevents exponential path blowup during path stitching. However, it incurs a preformance cost and for that reason it was disabled by default.
The problem is that users cannot pass along the right stitcher configuration in all places where stitching is used. If the rules for a language can result in exponential blowup, users have no way of preventing that at the moment.
This PR changes the partial path stitcher to use similar path detection by default. This will make the library safe and unblock other work depending on this to work. In the future, users should be able to pass along stitcher configuration everywhere it is relevant. This work is tracked in issue #322.