Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DDL for dropping sequence and auto_increment #68

Closed
wants to merge 4 commits into from

Conversation

davidpiegza
Copy link

@davidpiegza davidpiegza commented Aug 25, 2023

Description

This PR adds support to drop a sequence and auto_increment in VSchema in case it needs to be rolled back in a migration.

Drop a sequence

ALTER VSCHEMA DROP SEQUENCE test_seq

Drop auto_increment

ALTER VSCHEMA ON test_table DROP AUTO_INCREMENT

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: David Piegza <697113+davidpiegza@users.noreply.github.com>
Signed-off-by: David Piegza <697113+davidpiegza@users.noreply.github.com>
@davidpiegza davidpiegza marked this pull request as ready for review August 29, 2023 13:25
@davidpiegza davidpiegza marked this pull request as draft August 29, 2023 13:26
@arthurschreiber
Copy link
Member

One small suggestion - when dropping the auto increment I don't think we need to specify the sequence name?

This should be enough:

ALTER VSCHEMA ON test_table DROP AUTO_INCREMENT;

Signed-off-by: David Piegza <697113+davidpiegza@users.noreply.github.com>
Signed-off-by: David Piegza <697113+davidpiegza@users.noreply.github.com>
@github-actions
Copy link

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale label Sep 29, 2023
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants