-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added GitHub app authentication #97
Conversation
@henrymcconville can we merge this PR? Would love to have this feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've marked one of my comments IMPORTANT
and added a few minor nitpicks that would be good to address but aren't critical. Would you also be able to rebase off the master
branch to resolve the conflicts in config.go
and go.sum
. Thanks!
Thanks @henrymcconville ! |
@henrymcconville I removed duplicated code and added some fields to the Config struct. |
@galbirk Think a separate struct would be nicer but happy with it as is for now. Feel free to raise a follow up PR if you're passionate enough about it being separated 😄 |
In this PR I added the feature of authenticating to GitHub API with github app and allowing to fetch metrics about it.
Tests:
Closes #95