Skip to content
This repository has been archived by the owner on Jan 22, 2024. It is now read-only.

Update setting personal access token (PAT) instruction #33

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mohammad-oghli
Copy link

The instruction for creating personal access tokens need to be updated using classic tokens type and adding write scope to the permissions #26

README.md Outdated
@@ -22,7 +22,7 @@ Please complete the instructions below:

1. Create an organization-owned copy of this repository using the [Use this template](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-from-a-template#creating-a-repository-from-a-template) button.
2. Create a personal access token (PAT) of type **classic tokens** with the `read:org` and `write:org` scope selected.
3. Store the PAT as an [organization secret](https://docs.github.com/en/codespaces/managing-codespaces-for-your-organization/managing-encrypted-secrets-for-your-repository-and-organization-for-codespaces#adding-secrets-for-an-organization) titled `EXERCISE_PAT`. We recommend making the secret available only to your newly created repository.
3. Store the PAT as an [organization secret](https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository) titled `EXERCISE_PAT` in actions tab. We recommend making the secret available only to your newly created repository.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storing the PAT as organization secret should be for a repository on actions tab and not for codespaces #26

@@ -22,7 +22,7 @@ Please complete the instructions below:

1. Create an organization-owned copy of this repository using the [Use this template](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-from-a-template#creating-a-repository-from-a-template) button.
2. Create a personal access token (PAT) of type **classic tokens** with the `read:org` and `write:org` scope selected.
3. Store the PAT as an [organization secret](https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository) titled `EXERCISE_PAT` in actions tab. We recommend making the secret available only to your newly created repository.
3. Store the PAT as an [organization secret](https://docs.github.com/en/actions/security-guides/encrypted-secrets#creating-encrypted-secrets-for-a-repository) titled `EXERCISE_PAT` in actions tab. We recommend making the secret available only to your newly created repository. Then go to organizaion setting and from **Actions** tab -> **General** set the Workflow permissions to `read and write permissions`.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step should be done in organization setting in actions tab #26

@@ -21,7 +21,7 @@ This exercise checks your ability to manage GitHub Apps for your organization. I
Please complete the instructions below:

1. Create an organization-owned copy of this repository using the [Use this template](https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/creating-a-repository-from-a-template#creating-a-repository-from-a-template) button.
2. Create a personal access token (PAT) with the `read:org` scope selected.
2. Create a personal access token (PAT) of type **classic tokens** with the `read:org` and `write:org` scope selected.
Copy link
Author

@mohammad-oghli mohammad-oghli Aug 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Select classic tokens and add write scope #26

@mohammad-oghli
Copy link
Author

mohammad-oghli commented Aug 20, 2023

please review the PR @hectorsector

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant