Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes to the training scripts #400

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

jessehouwing
Copy link
Contributor

@jessehouwing jessehouwing commented May 17, 2023

  • Doesn't make repos private (cause private repos can't use Pages and Advanced Security and other potentially interesting repos)
  • Increases wait times to prevent secondary rate limits
  • Fixes python ssl error by downgrading urllib3 to v2.
  • Removes github project creation, cause it's broken. Needs to be replaced with Projects V2 at some point.
  • Fixing for New Computers #394 Automatically imports bash env variables
  • Changes ubuntu to jammy.

@amyschoen
Copy link
Collaborator

@jessehouwing, I merged my fix for #394 into this branch now that @parkerbxyz got me approved. I see that #390 looks like it fixes upgrading projects to v2. I hadn't considered the impact of making projects private on .com. We've been teaching on GHES historically, so Pages still work. I also like the idea of adding in Advanced Security as a part of the class. There are a lot of possibilities there.

@jessehouwing
Copy link
Contributor Author

I hadn't considered the impact of making projects private on .com. We've been teaching on GHES historically, so Pages still work. I also like the idea of adding in Advanced Security as a part of the class. There are a lot of possibilities there.

@amyschoen We're teaching mostly through the GitHub Professional Services Partner Program and use the GitHub provided ps-developers-sandbox org to teach this class.

There is an admin class and a ghas class as well that already explains advanced security, but it's easier if the users are in a fully enabled public repo where a demo or answer to a question may lead to demoing these advanced features.

@jessehouwing
Copy link
Contributor Author

Now that there is a gh cli extension to create and setup projects, it's probably a lot easier to use and maintain that. Which is true for many other elements of this class. It would do away with many a hairy API call and is probably more long-term compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants