Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proper guidelines for GitLab nginx configs #248

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proper guidelines for GitLab nginx configs #248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions install/centos/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,7 +616,16 @@ To do so, follow the instructions provided by the [nginx wiki][nginx-centos] and
yum update
yum -y install nginx
chkconfig nginx on

Copy GitLab config for nginx:

# NO SSL
wget -O /etc/nginx/conf.d/gitlab.conf https://gitlab.com/gitlab-org/gitlab-ce/raw/master/lib/support/nginx/gitlab-ssl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-ssl should point to https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/support/nginx/gitlab

Can you fix it?


or

# SSL
# wget -O /etc/nginx/conf.d/gitlab.conf https://gitlab.com/gitlab-org/gitlab-ce/raw/master/lib/support/nginx/gitlab-ssl
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be a comment in my opinion, since you choose one or the other.


Edit `/etc/nginx/conf.d/gitlab.conf` and replace `git.example.com` with your FQDN. Make sure to read the comments in order to properly set up SSL.

Expand Down