-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor preview environment and image build methods #19652
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iQQBot
force-pushed
the
pd/test-new-preview
branch
from
April 23, 2024 09:45
0e6249f
to
f8c9a6a
Compare
iQQBot
force-pushed
the
pd/test-new-preview
branch
from
April 23, 2024 11:59
f8c9a6a
to
bb3e116
Compare
iQQBot
force-pushed
the
pd/test-new-preview
branch
15 times, most recently
from
April 24, 2024 18:19
3ec58ea
to
3b94ea1
Compare
iQQBot
force-pushed
the
pd/test-new-preview
branch
from
April 26, 2024 18:25
545292a
to
f77915a
Compare
|
/unhold |
mustard-mh
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
/unhold |
kylos101
reviewed
May 7, 2024
diff-apply "${PREVIEW_K3S_KUBE_CONTEXT}" stripe-api-keys.secret.yaml | ||
rm -f stripe-api-keys.secret.yaml | ||
|
||
yq w -i "${INSTALLER_CONFIG_PATH}" "experimental.webapp.server.stripeSecret" "stripe-api-keys" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces significant refactoring to improve the security and efficiency of our deployment and build processes across the Gitpod infrastructure.
Key Changes
Preview Environment Create and Destroy:
Kubernetes Cluster and Secret Management:
core-dev
Kubernetes cluster by adopting Google Secret Manager for handling secrets more securely and efficiently.Build Process Refactoring:
gitpod-web-extension
and thexterm web IDE
. These are now built directly within the Gitpod repository rather than their respective repositories. Correspondingcommit ids
in theWORKSPACE.yaml
need updating to reflect these changes.Service Account Key Management:
fluent-bit
andgcr sa
, transitioning to VM service accounts that generate short-term tokens. This enhances security by reducing the attack surface associated with long-term credentials.Artifact Storage Location:
eu.gcr.io/gitpod-dev-artifact/build/
, while artifacts from the main branch continue to reside in the same location.These changes are aimed at hardening our supply chain by reducing dependencies and improving security across our development operations.
Related Issue(s)
Fixes ENG-1963
Fixes ENG-2079
Part of ENG-1950
Part of ENG-2037
How to test
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold