Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Better registration errors #253

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

jamesread
Copy link
Collaborator

@jamesread jamesread commented Sep 24, 2024

What kind of change does this PR introduce?

feature

Why was this change needed?

Lots of people seem to get errors when trying to register their first user, this should helpfully soften it.

This also fixes a few bugs;

  • Registration errors that are not HTTP 400 (eg, CORS errors, HTTP 404, etc) will now render an error message (previously nothing happened from a user's perspective).
  • If the user doesn't need activating, they are redirected to the login page.

Other information:

Very new to coding with react, I'm not sure what is idiomatic at the moment, so just gave this a go as a relatively small change.

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitroom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 0:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
postiz ⬜️ Ignored (Inspect) Visit Preview Sep 24, 2024 0:58am

@nevo-david nevo-david merged commit 9e2c825 into main Sep 24, 2024
9 checks passed
@nevo-david nevo-david deleted the feat-better-registration-errors branch November 16, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants