Get endpoint uri test

[adrianvrj]

Added two test cases for get_endpoint_uri function, in case an endpoint is found and in case it is not.

[Gonmeso]

Thank you for your input!

Couple of things:

• You should update this branch with the latest changes in main as we have added testing in the CI
• Run pre-commit which would format and order the imports
• Add the data for the test inside the tests for clarity

[Gonmeso]

This file is missing formatting, this should have been handled by pre-commit, make sure it is installed and run pre-commit run --files tests/test_utils.py

[adrianvrj]

Already done this, you can see it at 08cf401 commit

[Gonmeso]

Running pre-commit locally yields changes:

Check Yaml...........................................(no files to check)Skipped
Fix End of Files.........................................................Passed
Trim Trailing Whitespace.................................................Passed
Check for added large files..............................................Passed
Check for merge conflicts................................................Passed
Don't commit to branch...................................................Passed
pyupgrade................................................................Passed
isort....................................................................Failed
- hook id: isort
- files were modified by this hook

Fixing /Users/gonmeso/src/external/actions-sdk/tests/test_utils.py

black....................................................................Failed
- hook id: black
- files were modified by this hook

reformatted tests/test_utils.py

All done! ✨ 🍰 ✨
1 file reformatted.

ruff.....................................................................Failed
- hook id: ruff
- exit code: 1

tests/test_utils.py:1:1: F403 `from unittest.mock import *` used; unable to detect undefined names
tests/test_utils.py:3:8: F401 [*] `pytest` imported but unused
tests/test_utils.py:9:2: F405 `patch` may be undefined, or defined from star imports
tests/test_utils.py:29:2: F405 `patch` may be undefined, or defined from star imports
Found 4 errors.
[*] 1 fixable with the `--fix` option.

Run pre-commit run --files tests/test_utils.py and fix the formating and linting issues

[adrianvrj]

I think now I get it right

[adrianvrj]

[Gonmeso]

To improve readability a bit we could add this inside the test and add it to the mock:

@patch("giza.client.EndpointsClient.list")
def test_get_endpoint_uri_successful(mock_get):
    """
    Tests successful retrieval of the deployment URI for a model and version.
    """
    endpoint_data = Endpoint(id=999, size="S", is_active=True, model_id=999, version_id=999, uri="testing.uri")
    endpoint_list = EndpointsList(root=[endpoint_data])
    mock_get.return_value = endpoint_list
    uri = get_endpoint_uri(model_id=788, version_id=23)
    assert uri is "testing.uri"
    mock_get.assert_called_once()

This way data that its only for a test its contained inside and not for the whole script. Make sure to change the test_get_endpoint_uri_not_found test as well.

[adrianvrj]

Already done this too, it is the df54f72 commit

[adrianvrj]

@Gonmeso I also informed the other devs in charge of this issue to make this corrections.

[Gonmeso]

Importing with * is considered a bad practice and usually discouraged in lintiing tools, only import what is needed, which is patch

[adrianvrj]

Fixed here d3bd146

[Gonmeso]

Two other tests have been added by your colleague, please update from main to add them and fix any conflict, then it will be good to go!

[Gonmeso]

LGTM!