adding type hinting #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Gerson2102 if you could paste the errors maybe we can offer a helping hand |
|
For sure: All the errors that starts with "Cannot find" I ignored them. |
|
Taking out the "library is missing stubs" ones these are left: I think that besides this one: Others can be tackle as well, some of them require code changes and not just typing, for example # this would give a similar error
# word type hint is: Optional[str]
word.upper()
# Adding a check that word is none should fix the error
if word is not None:
word.upper()
else:
# Here we could handle if word = None, maybe raising an exception if necessary
...Also, @Gerson2102 make sure to update your fork as it seems to be missing the latest changes, making the CI fail.
|
|
I dont know why the CI keep failing. I did a git rebase and everything should be good. |
Gonmeso
requested changes
Apr 24, 2024
There was a problem hiding this comment.
The old agents.py functions should be handled as this is old behaviour and it needs to be improved. With the updates it might have been done along the way. This needs to be fixed for the PR to be merged.
Pre-commit check is failing in the CI check
Make sure to install and run pre-commit prior to comitting the changes.
|
Right now, I'm just getting this error: |
|
Dont worry about this you have done a great job, we need the CI to pass and some simple things |
Gonmeso
requested changes
Apr 25, 2024
giza_actions/model.py
Outdated
| @@ -275,7 +278,7 @@ def predict( | |||
| output_dtype = self._get_output_dtype() | |||
| else: | |||
| output_dtype = custom_output_dtype | |||
|
|
|||
| output_dtype = output_dtype or "DefaultType" | |||
There was a problem hiding this comment.
I would say that shi change is not needed, as this is handled in the if else.
There was a problem hiding this comment.
I get it. But if i change it, we will have another error.
There was a problem hiding this comment.
Let this error be I'll handle it. Remove this line and the PR will be merged as CI is passing 🥳
There was a problem hiding this comment.
Let this error be I'll handle it. Remove this line and the PR will be merged as CI is passing 🥳
Finally haha!
|
CI tests fails due to circular imports, this is due to importing classes just for type checking. Check this https://mypy.readthedocs.io/en/stable/runtime_troubles.html#import-cycles |
|
@Gonmeso Lets see if we are done here. |
|
Incredible work @Gerson2102 ! LGTM! |
Gonmeso
approved these changes
Apr 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a lot more types to functions and parameters. There are still some errors, but I dont understand them, maybe somebody can help me.
This is the related issue: #36