Fixed the issue where nil for header_ids #324
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have fixed the issue where specifying
nil
for:header_ids
in the:extension
config would result in thenil
option being cleared when reusing the config.Target Version
https://github.com/gjtorikian/commonmarker/tree/v2.0.0/ext/commonmarker
Use Case
Expected Output
<h1>Heading-1</h1>
Actual Output in
<h1><a href=\"#heading-1\" aria-hidden=\"true\" class=\"anchor\" id=\"heading-1\"></a>Heading-1</h1>