Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change sitting animation on 47's bedroom balcony sunbed to match the sunbed outside #227

Closed
wants to merge 2 commits into from

Conversation

dribbleondo
Copy link
Contributor

fixes #226

@VoodooHillbilly
Copy link
Contributor

Did you intend to move these, or did Glacier Kit add more unrelated m_mTransform changes?

  • 5e5f0e35f3b8f107 Vase_Italy_E_Small_01
  • 7d8c712ada43d797 chair_relaxing_hokaido_b_01

@dribbleondo
Copy link
Contributor Author

dribbleondo commented Nov 13, 2024

Did you intend to move these, or did Glacier Kit add more unrelated m_mTransform changes?

  • 5e5f0e35f3b8f107 Vase_Italy_E_Small_01
  • 7d8c712ada43d797 chair_relaxing_hokaido_b_01

Checking this now; I recall the latter is deliberate, but the former definitely isn't.

EDIT: both are being purged.

@dribbleondo
Copy link
Contributor Author

Done.

@VoodooHillbilly
Copy link
Contributor

LGTM now.

@Ocean-Minnow
Copy link
Contributor

I'm holding off on merging this until I can clear up the confusion on the issue page. 47 is already laying down in that image, so what does this patch change exactly?

@dribbleondo
Copy link
Contributor Author

dribbleondo commented Nov 14, 2024

I'm holding off on merging this until I can clear up the confusion on the issue page. 47 is already laying down in that image, so what does this patch change exactly?

In vanilla, he sits like this:

image

This patches change it to 47 laying down, as he does on other sunbeds, including the one outside on the ground floor.

image

@Ocean-Minnow
Copy link
Contributor

Ah, I see. Are you sure this is a bug and not an intentional design choice?

@dribbleondo
Copy link
Contributor Author

dribbleondo commented Nov 14, 2024

Considering all the other sunbeds in WOA are either ones you lay down on or cannot access, I'd say this is a bizaare choice if it's intentional. This fix keeps it consistent with other sunbeds.

This isn't necessarily a bug, but it's certainly a weird inconsistency.

I'd even go so far as to say that this was probably a placeholder until they linked up the right entity (which they did do on the sunbed downstairs).

@VoodooHillbilly
Copy link
Contributor

Is this animation applying to all the furniture for you too?
chair1
chair2

@Ocean-Minnow
Copy link
Contributor

Ocean-Minnow commented Nov 19, 2024

I'd even go so far as to say that this was probably a placeholder until they linked up the right entity

This doesn't make sense to me. You're saying they only placed down half a deck chair (despite their editor bundling such things together), but did bother to put in a different interaction animation (which I really doubt requires less effort, especially given that no other deck chair does this and so they'd have to set up a new interaction for it), and then just left it for long enough that they managed to forget to replace it? How would that happen?

Why put in a placeholder animation at all? Why not simply leave the object non-interactable until it's got the right animation? It just doesn't add up :/

@dribbleondo
Copy link
Contributor Author

Is this animation applying to all the furniture for you too? chair1 chair2

Oh god, that's not something I noticed. How is that happening?!

I'm gonna close this issue, mostly because there isn't much of a consensus, and I'm starting to think this might be out of scope for the mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunbed on 47's bedroom balcony has the wrong sitting animation
3 participants