-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DNM] DRAFT - experimental - try strict mode React + Relay hooks #132
base: master
Are you sure you want to change the base?
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/gladly-team/tab-web/4pFF9isXP6SHQmJHWwyMUTwiqyCE |
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 89.29% 89.13% -0.17%
==========================================
Files 82 82
Lines 1149 1150 +1
Branches 268 266 -2
==========================================
- Hits 1026 1025 -1
- Misses 110 112 +2
Partials 13 13
Continue to review full report at Codecov.
|
The ultimate goal of this exploration is to use Relay hooks. This should allow us to more easily use the Relay store correctly; for example, by returning Relay store data from
useData
, which currently suffers from rendering bugs for top-level pages when the Relay store changes.If we want to use Relay hooks now, we need to rely on an unstable React
Suspense
and consequently make sure all code is compatible with React strict mode.Some of the work this requires:
react@experimental
andreact-dom@experimental