-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 #40
base: master
Are you sure you want to change the base?
Python3 #40
Conversation
@@ -8,6 +8,7 @@ | |||
from loader import prepare_sentence | |||
from utils import create_input, iobes_iob, zero_digits | |||
from model import Model | |||
import pdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this?
@@ -3,7 +3,7 @@ | |||
import codecs | |||
import numpy as np | |||
import theano | |||
|
|||
import pdb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you remove this? as well as the print(words) and print('\n') below?
@@ -188,3 +186,6 @@ def augment_with_pretrained(dictionary, ext_emb_path, words): | |||
|
|||
word_to_id, id_to_word = create_mapping(dictionary) | |||
return dictionary, word_to_id, id_to_word | |||
|
|||
if __name__ == "__main__": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind removing this too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request! Do you mind removing the few extra imports / prints you added so that I can merge? Also, could you please remove the extra spaces that sometimes appear inside the parenthesis of the print function?
Python3 version of neural NER .