Add port_from_dynamic #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Aug 15, 2024
|
Added tests and updated changelog |
|
Would you mind rebasing on main please 🙏 |
|
rebased |
|
Maybe all the Port code should be in |
Just saw this after my review. You are totally right! We should move it there |
|
Made a PR over there gleam-lang/erlang#55. I think we should deprecate Port on here and use the one in |
|
Good idea. Would you mind changing this to deprecate it with a message to use gleam_erlang? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replicates behavior similar to pid_from_dynamic for handling ports