Generalize ZarrPixelsService.getUri to support additional entityType/entityId #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matches the repacking of the source code under the same namespace Also rename the ZarrPixelsServiceTest to match the PixelsService subclass
Add support for other externalInfo entityType/entityId Update the unit tests to cover both signatures of ZarrPixelsService
sbesson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new signature
ZarrPixelsService.getUri(IObject, String, String)allowing to specify custom entityType/entityId values to check in the object external info. The semantics ofZarrPixelsService.getUri(IObject)is unchanged and still checksNGFF_ENTITY_TYPEandNGFF_ENTITY_ID. The unit tests are adjusted to test both signatures.Noticed during the review of glencoesoftware/omero-ms-image-region#142, 141fb50 updates the remaining references to the previous package and use
com.glencoesoftware.omero.zarrconsistently. There are no functional changes, this is primarily tidy-up