WIP: Now using event timestamp to retrieve relevant logs. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,67 +153,25 @@ func (p *LogsPump) pumpLogs(event *docker.APIEvents, backlog bool) { | |||
| debug("pump.pumpLogs():", id, "ignored: environ ignore") | |||
| return | |||
| } | |||
| if !logDriverSupported(container) { | |||
There was a problem hiding this comment.
This drops the following functionality 324db6e.
There was a problem hiding this comment.
Damn it. I didn't mean to remove that commit.
mattatcha
force-pushed
the
duplicate-logs
branch
from
d665381
to
357e669
Compare
trying to hit /logs for a container that does not support that endpoint results in the following error in that container's stdout "Error running logs job: configured logging reader does not support reading"
|
@MattAitchison do you still want to pursue this route? |
|
@michaelshobbs yeah I do. I believe its a better route since it should prevent missing log output as described here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the event timestamp should prevent duplicate logs when a container restarts.