Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace declaration marked as deprecated (pageYOffset) #437

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Replace declaration marked as deprecated (pageYOffset) #437

merged 1 commit into from
Oct 30, 2023

Conversation

mathdevelop
Copy link
Contributor

Related Issue

'pageYOffset' is deprecated.

Proposed Changes

  • This is a legacy alias of scrollY, it should be replaced with it.

@vitorhugomattos
Copy link
Contributor

I don't think pageYOffset is deprecated and it has better support in older browsers, but scrollY could be more future-proof.

@vitorhugomattos vitorhugomattos merged commit bd8b443 into globocom:master Oct 30, 2023
6 checks passed
@mathdevelop mathdevelop mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathdevelop @vitorhugomattos