✨ Component : 모임인원 picker , 모임 방 만들기 UI 개선 및 swiper 로직 수정 #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Labeler가 제목과 설명에 있는 특별한 텍스트와 일치하는 레이블을 적용했습니다. |
guesung
reviewed
Jul 4, 2023
Comment on lines
-18
to
+21
| const setYearValue = (value: number) => { | ||
| const setValueByKeyType = (value: string | number, keyType: string) => { | ||
| setBirthdayValue({ | ||
| ...birthdayValue, | ||
| year: yearList[value], | ||
| }); | ||
| }; | ||
| const setMonthValue = (value: number) => { | ||
| setBirthdayValue({ | ||
| ...birthdayValue, | ||
| month: monthList[value], | ||
| }); | ||
| }; | ||
| const setDateValue = (value: number) => { | ||
| setBirthdayValue({ | ||
| ...birthdayValue, | ||
| date: dateList[value], | ||
| [keyType]: value, |
There was a problem hiding this comment.
오오 ,,, 아주 좋아요 !!!
이 코드가 조금 마음에 안들었는데 이렇게 간결화할 수 있군요
Comment on lines
+36
to
+50
| {({ isActive, isPrev, isNext }) => | ||
| isActive ? ( | ||
| <div className="flex justify-center items-center text-black2 text-66 font-700 pt-10"> | ||
| {slideContent} | ||
| </div> | ||
| ) : isPrev || isNext ? ( | ||
| <div className="flex justify-center items-center text-gray3 text-50 font-500 pt-30"> | ||
| {slideContent} | ||
| </div> | ||
| ) : ( | ||
| <div className="flex justify-center items-center text-gray8 text-35 font-500 pt-50"> | ||
| {slideContent} | ||
| </div> | ||
| ) | ||
| } |
There was a problem hiding this comment.
옹 globalcss가 아니라, 이런식으로 Swiper 내부의 속성을 설정할 수가 있군요 ?!
| }} | ||
| modules={[FreeMode]} | ||
| onSlideChange={(swiper) => setValue && setValue(swiper.activeIndex)} | ||
| initialSlide={initialValue ? selectList.indexOf(initialValue as never) : 0} |
There was a problem hiding this comment.
라이브러리에서 제공되는 initialValue가 never 타입으로 설정되어 있더군요! 그래서 임시로 일단 해뒀습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 왜 PR을 올렸나요?
💁 무엇이 어떻게 바뀌나요?
💬 리뷰어분들께