Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: #666

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Refactor: #666

merged 3 commits into from
Mar 19, 2024

Conversation

dev-dong-su
Copy link
Member

๐Ÿ’ก ์™œ PR์„ ์˜ฌ๋ ธ๋‚˜์š”?

  • ์‹ ๊ทœ ํ”ผ์ฒ˜

๐Ÿ’ ๋ฌด์—‡์ด ์–ด๋–ป๊ฒŒ ๋ฐ”๋€Œ๋‚˜์š”?

ํŒŒ์ผ ์ด๋ฆ„ ๋’ค์— .client๋ฅผ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.

2f92f93

์ผ๋ถ€ ์ปดํฌ๋„ŒํŠธ์˜ ๋‹ค๊ตญ์–ด์ง€์› ๋ฐฉ์‹ฑ ๋ณ€๊ฒฝ

์ผ๋ถ€ ssr์ด ๊ฐ€๋Šฅํ•œ ์ปดํฌ๋„ŒํŠธ์˜ useTranslate hook์„ ์ œ๊ฑฐํ•˜๊ณ  srr์ด ๊ฐ€๋Šฅํ•˜๋„๋ก serverTranslate ํ›…์œผ๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
2f92f93

๋Œ€ํ‘œ์ž ํ•ธ๋“œํฐ ๋ฒˆํ˜ธ ๋…ธ์ถœ ์ œ๊ฑฐ ๋ฐ ์ธ์ฆ๋ฒˆํ˜ธ๊ฐ€ ์ „์†ก๋˜์ง€ ์•Š๋Š” ๋ฒ„๊ทธ ์ˆ˜์ •

cacf8fc

๋นŒ๋“œ ์˜ค๋ฅ˜ ์ˆ˜์ •

f5ba34d

๐Ÿ’ฌ ๋ฆฌ๋ทฐ์–ด๋ถ„๋“ค๊ป˜

@dev-dong-su dev-dong-su merged commit 3785adb into develop Mar 19, 2024
6 checks passed
@dev-dong-su dev-dong-su deleted the refactor/665-opt-refactor branch March 19, 2024 09:17
guesung pushed a commit that referenced this pull request Jul 12, 2024
@dev-dong-su
Refactor: (#666)
16ac93f 
* refactor: ์ด๋ฆ„ ๋ณ€๊ฒฝ .client ์ œ๊ฑฐ ๋ฐ ๋‹ค๊ตญ์–ด ssr

* refactor: numberform ํ•ธ๋“œํฐ ๋ฒˆํ˜ธ ์ œ๊ฑฐ

* fix: ๋นŒ๋“œ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
guesung pushed a commit that referenced this pull request Jul 17, 2024
@dev-dong-su
Refactor: (#666)
983142f 
* refactor: ์ด๋ฆ„ ๋ณ€๊ฒฝ .client ์ œ๊ฑฐ ๋ฐ ๋‹ค๊ตญ์–ด ssr

* refactor: numberform ํ•ธ๋“œํฐ ๋ฒˆํ˜ธ ์ œ๊ฑฐ

* fix: ๋นŒ๋“œ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
guesung pushed a commit that referenced this pull request Jul 17, 2024
@dev-dong-su
Refactor: (#666)
71a53f2 
* refactor: ์ด๋ฆ„ ๋ณ€๊ฒฝ .client ์ œ๊ฑฐ ๋ฐ ๋‹ค๊ตญ์–ด ssr

* refactor: numberform ํ•ธ๋“œํฐ ๋ฒˆํ˜ธ ์ œ๊ฑฐ

* fix: ๋นŒ๋“œ ์˜ค๋ฅ˜ ํ•ด๊ฒฐ
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guesung guesung Awaiting requested review from guesung guesung is a code owner

Assignees

@dev-dong-su dev-dong-su

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dev-dong-su