Add UI for Jupyter export tool #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat we can reuse it for a Jupyter dialog.
|
Codecov is failing, but we can worry about that when we add tests for the tools (which is something that should happen soon). |
Carifio24
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a UI for the Jupyter export tool. The layout is essentially the same the as the Qt export dialog, since the same options are available. Because of this, I've factored all of the frontend-agnostic pieces into a base export dialog class that we now inherit from for both the Qt and Jupyter versions.
The Jupyter dialog is an ipyvuetify widget created using a Vue template, with the exception of the layer-specific pieces which are created Python-side and inserted into the template via a
jupyter-widget. I originally had these as ipyvuetifyTextFields, but ultimately ended up creating small custom Vuetify templates in order to make validation rules work.