Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for scatter layers when determining ipyvolume volume resolution #64

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

Carifio24
Copy link
Member

Currently if an ipyvolume volume viewer contains scatter layers, the viewer resolution will always be returned as 256, regardless of what the volume layers are doing. This is due to the default value in the getattr call. This PR updates the resolution calculation to ignore layers that don't have a max_resolution attribute.

@Carifio24 Carifio24 added bug Something isn't working ipyvolume Related to export from ipyvolume viewers labels Oct 3, 2024
@Carifio24 Carifio24 merged commit 5a6f7eb into glue-viz:master Oct 3, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ipyvolume Related to export from ipyvolume viewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant