Add regiondata #2442
Add regiondata #2442
Conversation
|
|
||
| result._extended_component_id = context.object(rec["_extended_component_id"]) | ||
|
|
||
| def fix_special_component_ids(ext_data): |
There was a problem hiding this comment.
@astrofrog -- this is a hacky function I would like to eliminate, but I'm not sure how to rewrite the save/load logic to deal with the underlying problem. The basic problem is that when I restore a session, the ComponentIDs stored inside of an ExtendedComponent are no longer the same as the ComponentIDs for the actual components they reference. I think they are being created separately. This hacky function works, but would fail if there are multiple attributes with the same name/label.
There was a problem hiding this comment.
Can you save the UUIDs of these attributes when saving the session, then you can more easily match it up to the correct attribute not relying on the name when you re-load them?
There was a problem hiding this comment.
Yeah, that should work. Thanks for the idea!
There was a problem hiding this comment.
This solution involves saving ComponentID uuids into the session file and restoring them (if present) from the session file. I don't think this introduces and backwards-incompatibility problems (all tests pass) but does that seem okay to you?
|
|
||
| result._extended_component_id = context.object(rec["_extended_component_id"]) | ||
|
|
||
| def fix_special_component_ids(ext_data): |
There was a problem hiding this comment.
Can you save the UUIDs of these attributes when saving the session, then you can more easily match it up to the correct attribute not relying on the name when you re-load them?
|
@astrofrog -- I think this is ready now. I would love to get it merged in before opening the PRs for adding RegionData to the viewers. |
Add RegionData and ExtendedComponent Types
Description
This is a replacement for #2373 which provides just the glue-core pieces of that PR and some additional improvements. As a standalone piece it doesn't do very much, but it provides the underlying architecture so that Viewers can be extended to deal with regions-as-data.
The pieces here are:
ExtendedComponent(Component)which takes a list of Shapely geometries and a list of ComponentIDs describing the center of these geometries.RegionData(Data)object which has one (and only one)ExtendedComponentand is the general class to use for any regions-as-data.Some additions over #2373 are that this no longer requires us to
allow_pickleinnp.loadand it properly round-trips through session files, albeit with a bit of a hack to get the ComponentIDs to be all correct.Closes #2351 , #2086 , #1686