Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 3.8 and 3.9 #2514

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

CyclingNinja
Copy link
Contributor

Removes old python versions from builds and min required python

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment below - also could you check whether the documentation needs updating in the installation instructions? (regarding the minimum version of Python)

@@ -11,6 +11,8 @@ classifiers =
Programming Language :: Python :: 3.8
Programming Language :: Python :: 3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove 3.8 and 3.9 here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been forgotten

@astrofrog astrofrog changed the title Remove python 38 and 39 from min python Drop support for Python 3.8 and 3.9 Sep 17, 2024
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I reworded the title just as this gets used for the user-facing change notes

@astrofrog astrofrog merged commit 7481caf into glue-viz:main Sep 17, 2024
23 of 25 checks passed
@dhomeier
Copy link
Collaborator

A bit puzzled why py310-test-dev is still running here, but not for glue-qt – is astropy>=0.0.dev0 resolved differently from git+https://github.com/astropy/astropy (weekly wheels or something)?
Either way this may still start to fail here as well once the former are updated to astropy HEAD.
Also does the LTS test need no replacement?

@dhomeier
Copy link
Collaborator

dhomeier commented Sep 23, 2024

Either way this may still start to fail here as well once the former are updated to astropy HEAD.

@astrofrog, @CyclingNinja, astropy>=0.0.dev0 is now getting astropy==6.1.3 installed on py310-test-dev, so one dev test should probably be pushed to py312 (#2518).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants