Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AttachExtended Project to be compatible with Attach project latest (4.0.22-SNAPSHOT) #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctoabidmaqbool
Copy link

  1. Aligned AttachExtended version with Attach becase, AttachExtended project is just like duplicate copy having custome implmentation for user's plugins and it's dependent upon Attach -> Util plugin!
  2. Try to update structure and libs of Attach project;

…test (4.0.22-SNAPSHOT).

Aligned AttachExtended version e.g. 4.0.22-SNAPSHOT with Attach Project.
@ctoabidmaqbool
Copy link
Author

@jperedadnr @abhinayagarwal @johanvos!
Please review it's I think, AttachExtendended must be same as Attach!
#11

@jperedadnr
Copy link
Collaborator

Thanks for your PR.

AttachExtended is a playground repo, it is more like a demo/tutorial for people to understand how to create their own custom Attach service, and doesn't need to be up to date all the time.

We are not against keeping up to date, though. However, it doesn't make sense to update it now with a snapshot of Attach.

Let's just wait until we release Attach 4.0.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants