bump SDK version and add await to failing test (#19)

gluonhq · Nov 28, 2024 · e00a5b4 · e00a5b4
1 parent 2187ede
commit e00a5b4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 9 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -24,11 +24,11 @@ jobs:
         os: [ macos-latest, ubuntu-latest, windows-latest ]
         include:
           - os: macos-latest
-            FILE: openjfx-24+879_headless_mac-aarch64_bin-sdk
+            FILE: openjfx-24+884_headless_mac-aarch64_bin-sdk
           - os: ubuntu-latest
-            FILE: openjfx-24+876_headless_linux-x86_64_bin-sdk
+            FILE: openjfx-24+881_headless_linux-x86_64_bin-sdk
           - os: windows-latest
-            FILE: openjfx-24+880_headless_windows-x86_64_bin-sdk
+            FILE: openjfx-24+885_headless_windows-x86_64_bin-sdk
 
     runs-on: ${{ matrix.os }}
     timeout-minutes: 20

diff --git a/subprojects/testfx-junit/src/test/java/org/testfx/cases/acceptance/ApplicationStartTest.java b/subprojects/testfx-junit/src/test/java/org/testfx/cases/acceptance/ApplicationStartTest.java
@@ -22,7 +22,6 @@
 import javafx.beans.InvalidationListener;
 import javafx.scene.Scene;
 import javafx.scene.control.Button;
-import javafx.scene.input.MouseButton;
 import javafx.stage.Stage;
 
 import org.junit.Rule;
@@ -50,12 +49,12 @@ public void init() throws Exception {
     @Override
     public void start(Stage stage) {
         CountDownLatch setSceneLatch = new CountDownLatch(1);
-        setButtonTextLatch = new CountDownLatch(1);
         InvalidationListener invalidationListener = observable -> setSceneLatch.countDown();
         stage.sceneProperty().addListener(observable -> {
             setSceneLatch.countDown();
             stage.sceneProperty().removeListener(invalidationListener);
         });
+        setButtonTextLatch = new CountDownLatch(1);
         Button button = new Button("click me!");
         button.setOnAction(actionEvent -> {
             button.setText("clicked!");
@@ -85,13 +84,12 @@ public void should_contain_button() {
     }
 
     @Test(timeout = 3000)
-    public void should_click_on_button() {
+    public void should_click_on_button() throws InterruptedException {
         // when:
-        moveTo(".button");
-        press(MouseButton.PRIMARY);
-        release(MouseButton.PRIMARY);
+        clickOn(".button");
 
         // then:
+        setButtonTextLatch.await(3, TimeUnit.SECONDS);
         verifyThat(".button", hasText("clicked!"), informedErrorMessage(this));
     }