introduce downloadable sprites #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jperedadnr
reviewed
Aug 12, 2024
emoji-offline/src/main/java/com/gluonhq/emoji/LocalEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
samples/introduction/src/main/java/com/gluonhq/sample/Main.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
samples/nodes/src/main/java/com/gluonhq/emoji/samples/Demo.java
Outdated
Show resolved
Hide resolved
jperedadnr
reviewed
Aug 19, 2024
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
samples/nodes/src/main/java/com/gluonhq/emoji/samples/Demo.java
Outdated
Show resolved
Hide resolved
samples/nodes/src/main/java/com/gluonhq/emoji/samples/Demo.java
Outdated
Show resolved
Hide resolved
johanvos
reviewed
Aug 19, 2024
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
johanvos
reviewed
Aug 19, 2024
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
johanvos
reviewed
Aug 19, 2024
emoji/src/main/java/com/gluonhq/emoji/DownloadbleEmojiSpriteLoader.java
Outdated
Show resolved
Hide resolved
tiainen
reviewed
Aug 20, 2024
emoji/src/main/java/com/gluonhq/emoji/DownloadableEmojiSpriteLoader.java
Show resolved
Hide resolved
tiainen
reviewed
Aug 20, 2024
emoji/src/main/java/com/gluonhq/emoji/DownloadableEmojiSpriteLoader.java
Show resolved
Hide resolved
johanvos
approved these changes
Aug 22, 2024
jperedadnr
reviewed
Aug 23, 2024
jperedadnr
reviewed
Sep 11, 2024
| @@ -45,12 +49,46 @@ | |||
|
|
|||
| public class Demo extends Application { | |||
|
|
|||
| private StackPane root; | |||
There was a problem hiding this comment.
Not needed, but if you want, add a logging.properties file, so tests can be done with fine level.
samples/introduction/src/main/java/com/gluonhq/sample/Main.java
Outdated
Show resolved
Hide resolved
johanvos
reviewed
Sep 13, 2024
| Path tmpFilePath = getTmpFilePath(size); | ||
| if (Files.exists(tmpFilePath)) { | ||
| LOG.fine("Temporary download file found"); | ||
| LOG.fine("Delete file and re-try downloading"); |
There was a problem hiding this comment.
Increase log-level here. This is something that should only happen in rare occasions.
There was a problem hiding this comment.
Do you want all logging to happen at info level or just this one?
There was a problem hiding this comment.
Just that one.
While we are developing ourselves, we can easily increase the log level to check detailed logging.
But in case this is happening with users, and when they submit logs, only logs with INFO or higher are considered.
abhinayagarwal
commented
Sep 13, 2024
| } | ||
|
|
||
| private Path getLockFilePath(int size) { | ||
| return Paths.get(String.format(LOCAL_PATH, commit)).resolve(size + ".downloading"); |
There was a problem hiding this comment.
does the extension .downloading makes sense or should I update it to .lck ?
There was a problem hiding this comment.
It doesn't really matter, but probably .lck or .tmp is better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32