Patch v0.62.0 #20
Merged
Patch v0.62.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a wrapper around a block-based transport that encrypts and decrypts using an established Noise connection. Add a handshaker that establishes an encrypted Noise connection using the server-defined protocol. Implement the block-based transport trait on top of a websocket connection. Co-authored-by: Jordan Rose <jrose@signal.org>
Even in Validate mode, we still need real maps to resolve IDs. The HashMap/HashSet flexibility has moved to the *Data associated types of the ReferencedTypes trait.
Since the usual constructor is strongly typed, this can only happen when the serialized data is corrupted. But that is a possibility.
Convert the *Key and keyPair properties on *PreKeyRecord to throwing methods. Since the usual constructor is strongly typed, these should only throw when the serialized data is corrupted. But that is a possibility.
Lots of JNI calls can throw Java exceptions, not just those that directly invoke Java methods. By making jni's Error not directly convert to our own error types, calling code is encouraged to check for exceptions on any JNI call.
This will be off by default, unlike in previous releases of libsignal.
This saves potentially-costly calls to `read` across each bridge, especially if the app language side *isn't* buffering. The downside is that if the app side *is* buffering, we're spending more memory for less gain. But that's on the order of kilobytes, not megabytes.
./gradlew backup-tool:run --args "--hmac-key abcd --aes-key cdef
path/to/backup"
Ideally logs wouldn't be frequent enough for this to matter, but if they are, we shouldn't pay the price.
We weren't passing it along to the app anyway.
Co-authored-by: Ruben De Smet <ruben.de.smet@rubdos.be>
If a client has an unusual timestamp for one message in a conversation, it's likely to have many such messages. Dumping a screenful of logs isn't going to help with that.
This gains us a few percent of performance across a wide variety of operations, including 5% off of sealed sender decrypt, 10% off of backup validation, and double digits off of double ratchet decryption of successive messages (inner ratchet only). Unfortunately, the sha2-asm implementation crate doesn't support Windows. Hopefully sha2 0.11 is released soon for us to update to.
Co-authored-by: Jordan Rose <jrose@signal.org>
- Several timestamp fields become `optional` - Pin order also becomes `optional`, but 0 is still accepted for compatibility with existing tests - Contact now has `identityKey` and `identityState` - Quote type can be VIEW_ONCE
The x86 Android linker isn't happy with the object files, and that's our only x86 platform, and it's just the emulator anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.