Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add display for ui tests to jobs #319

Merged
merged 2 commits into from
May 9, 2024
Merged

add display for ui tests to jobs #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0323f72
add display for ui tests to jobs
jperedadnr May 9, 2024
29dbe55
don't run tests twice
jperedadnr May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: |
ver=$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout -f rta)
if [[ $ver == *"SNAPSHOT"* ]]; then
mvn -B -ntp deploy -f rta
mvn -B -ntp -Dmaven.test.skip=true deploy -f rta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was checking a previous run and it seems that the "Build project" phase don't run the tests. These are actually ran in "Publish Snapshots" step.

Considering this, I am of the opinion that we should remove the previous all together and make the build.yml similar to release.yml where both tests and deployment are done using the same step.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does run them: https://github.com/gluonhq/rich-text-area/actions/runs/8967621767/job/24625481389#step:4:34

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my bad. However, they run again in the next step.

I would prefer to remove the previous step to consistency across workflows. Thoughts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't remove Build project, as that is used for PRs. Publish Snapshots only applies when committed to main.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, now I see why it was divided into 2 steps to begin with. Thank you for reminding me :)

fi
shell: bash
env:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ jobs:
- name: Publish to Maven Central
id: deploy
run: |
export DISPLAY=:90
Xvfb -ac :90 -screen 0 1280x1024x24 > /dev/null 2>&1 &
mvn -q -Prelease deploy -f rta
echo ::set-output name=exit_code::$?
env:
Expand Down
Loading