Cache the value of internaltext in a unit buffer when it is not altered. #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mark a buffer dirty on any operation.
jperedadnr
approved these changes
Nov 17, 2024
True. I thought about doing those as well, but I didn't do that yet for the following reason: I have no 100% guarantees that the structure is not dirty unless we set it to dirty (there are possible paths outside the methods that now set dirty to true). In that case, there will be a mismatch between the text/length and internaltext that will lead to IndexOutOfBoundExceptions, which are a marker for wrong cache invalidations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark a buffer dirty on any operation.
Fix #377