Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Solution to Issue 171 #274

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

behrens-web
Copy link

The project I just submitted should display the number of accepted jobs and total jobs when the "Req Mgr" button is pressed on gngr. Accepted jobs will be on the left side of the "OK" button whereas Total jobs will be on the right side of the "OK" button.

I look forward to your input on my contribution.

Samuel Behrens added 2 commits May 12, 2021 14:02
Signed-off-by: Samuel Behrens <behrens.sam@uwlax.edu>
Signed-off-by: Samuel Behrens <behrens.sam@uwlax.edu>
@hrj
Copy link
Member

hrj commented May 13, 2021

Hey @behrens-web

This is a great start.

Quick comment: can you avoid committing changes to files that are not relevant to the PR? I am not sure what were the changes (Github diff says "empty file") but they were probably some minor changes.

I assume you are not that familiar with git yet.

It will help if you can do something like this:

  • git diff master..HEAD > ~/gngrPatch.txt
  • This will save all your changes in a text file ~/gngrPatch.txt.
  • git checkout master
  • git checkout -b newBranch
  • git apply ~/gngrPatch.txt : This will reapply all your changes on the new branch
  • Then commit only the changes that are relevant to this feature, and ignore the rest.
  • Make a new PR

Once I can see only the relevant changes, I will also be able to compile and try the changes on my system.

best,
HRJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants