[feat] supprt search total instances and global instance option #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little-cui
requested changes
Mar 14, 2024
| func WithIgnoreLease() OpOption { return func(op *OpOptions) { op.IgnoreLease = true } } | ||
| func WithCacheOnly() OpOption { return func(op *OpOptions) { op.Mode = ModeCache } } | ||
| func WithNoCache() OpOption { return func(op *OpOptions) { op.Mode = ModeNoCache } } | ||
| func WithGlobalInstanceSearch() OpOption { |
There was a problem hiding this comment.
2w实例下需要优化servicecomb-center注册微服务实例接口性能，经分析，注册实例接口性能主要卡在用递归算法计算当前已使用实例数，优化思路是在cache里维护已注册的所有实例数（包含全局实例数【sc自己】），获取已注册实例数需要用所有实例数-全局实例数，但是全局实例数较难维护，且全局实例数一般数量很少，计算它的实例数用递归也没有什么性能损耗，所以在cache只维护一个count变量表示所有实例数，用这两个选项表示到cache查的是所有注册实例数还是全局实例数。
There was a problem hiding this comment.
SC的实例数不是在初始化或者扩容等阶段就固定了吗？SC的实例考虑初始化的时候设定即可，主要是用原子计数考虑微服务实例数，感觉你说的有点复杂啊。
There was a problem hiding this comment.
这里的实例数指的是注册到引擎的微服务实例数，需要实时维护
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.