Add function to expose allowed methods for use in custom 405-handlers #884
+39
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flimzy
force-pushed
the
exposeAllowedMethods
branch
from
1fb5fed
to
f44bf53
Compare
context.go
Outdated
Comment on lines
40
to
46
| if rctx := RouteContext(ctx); rctx != nil { | ||
| result := make([]string, 0, len(rctx.methodsAllowed)) | ||
| for _, method := range rctx.methodsAllowed { | ||
| if method := methodTypString(method); method != "" { | ||
| result = append(result, method) | ||
| } | ||
| } |
There was a problem hiding this comment.
Hi, do you think it'd make sense to expose a method on rctx instead?
rctx := chi.RouteContext(ctx)
var methods []string = rctx.AllowedMethods()There was a problem hiding this comment.
That would serve my purpose just as well. I'm happy to update the PR, if that would get it merged.
There was a problem hiding this comment.
sounds good :) thank you
There was a problem hiding this comment.
I've made the requested change, and rebased on a current version of the master branch.
flimzy
force-pushed
the
exposeAllowedMethods
branch
from
f44bf53
to
86904e3
Compare
flimzy
force-pushed
the
exposeAllowedMethods
branch
from
86904e3
to
042e19b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #870