Rate-limit if increment > remaining limit #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VojtechVitek
commented
Jul 24, 2024
Comment on lines
-63
to
-66
| name: "no-block", | ||
| name: "no limit", | ||
| increment: 0, | ||
| requestsLimit: 3, | ||
| windowLength: 4 * time.Second, | ||
| respCodes: []int{200, 200, 429}, |
There was a problem hiding this comment.
This test has changed:
with increment = 2 and limit = 3,
the httprate middleware used to allow two requests in row
but with this change, it only allows one request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not allow requests with an increment higher than the remaining limit.
Example: A request with an increment of 100 should not be allowed if the remaining limit is only 99. However, other requests with an increment of 1 can still pass through.