Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce RespondOnLimit() vs. OnLimit() methods #44

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Conversation

VojtechVitek
Copy link
Contributor

Split the new .OnLimit() method into two explicit methods.

  1. RespondOnLimit() sends HTTP response
  2. OnLimit() doesn't

The OnLimit() method will be useful to use with tools like https://github.com/webrpc/webrpc, which always return some JSON payload and can't halt further request execution like regular HTTP handlers.

Copy link

Benchmark Results

goos: linux
goarch: amd64
pkg: github.com/go-chi/httprate
cpu: AMD EPYC 7763 64-Core Processor                
               │ master.txt  │               pr.txt               │
               │   sec/op    │   sec/op     vs base               │
LocalCounter-4   19.56m ± 1%   19.89m ± 1%  +1.69% (p=0.003 n=10)

               │  master.txt  │             pr.txt             │
               │     B/op     │     B/op      vs base          │
LocalCounter-4   2.832Mi ± 0%   2.833Mi ± 0%  ~ (p=0.481 n=10)

               │ master.txt  │            pr.txt             │
               │  allocs/op  │  allocs/op   vs base          │
LocalCounter-4   121.4k ± 0%   121.5k ± 0%  ~ (p=0.493 n=10)

@VojtechVitek VojtechVitek merged commit 5e681e3 into master Aug 23, 2024
3 checks passed
@VojtechVitek VojtechVitek deleted the UcA5MSt3 branch August 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant