Remotelink (web link) support #411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CmdIssueLink was created as a copy of CmdDup and the comment copied over at the same time. Signed-off-by: Jonathan Dowland <jon@dow.land>
This adds a new command "remotelink" which permits adding a remote (or web link) to an issue. Fixes go-jira#112. Signed-off-by: Jonathan Dowland <jon@dow.land>
taliastocks
reviewed
Mar 1, 2024
Comment on lines
+347
to
+354
| req := struct { | ||
| Object struct { | ||
| Url string `json:"url"` | ||
| Title string `json:"title"` | ||
| } `json:"object"` | ||
| }{} | ||
| req.Object.Url = url | ||
| req.Object.Title = title |
There was a problem hiding this comment.
If you ever pick this up again, would you mind adding support for other fields? e.g. https://github.com/phacility/phabricator/blob/5720a38cfe95b00ca4be5016dd0d2f3195f4fa04/src/applications/doorkeeper/worker/DoorkeeperJIRAFeedWorker.php#L230-L249
There was a problem hiding this comment.
I'm unlikely to return to this, to be honest; I think the odds of it being merged are close to zero. Although I'm still using a build with this in it personally. on my TODO list is to look at https://github.com/ankitpokhrel/jira-cli and see if that's a better candidate going forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new command "remotelink" which permits adding a remote (or
web link) to an issue.
This is (probably) pretty rough. This is my first attempt at writing Go! I have not
yet added verbs for fetching existing remote links, removing remote links, etc.
It's perfectly possible to add two or more remote links to an issue that are identical,
and it might be nice to detect and prevent that.