Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows (and update Linux) keyring support with zalando/go-keyring #467

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bkane-msft
Copy link

This PR replaces tmc/keyring (who's latest commit was in 2017) with zalando/go-keyring to update go-jira's keyring support.

go-keyring is:

  • actively maintained (with the latest update being only 3 days ago)
  • used by several projects.
  • Allows Windows users to use password-source: keyring
  • Updates Linux dbus support ( to godbux/dbus/v5)

This PR is an alternative to #460 (also see #459) for the reasons above and doesn't require @dougEfresh to maintain a fork. I meant to do this far sooner, but my son was born early!

Testing

I tested on MacOS and Windows with the following config:

config:
  stop: true
endpoint: <endpoint-url>
login: <my-username>
user: <my-username>
password-source: keyring 

and the commands:

go run ./cmd/jira login  # prompt to put password in keyring
go run ./cmd/jira logout  # remove stored JIRA session
go run ./cmd/jira login  # retrieve password from keyring and rebuild session

@strider
Copy link

strider commented Dec 15, 2022

Fixes my issue on MacOS while using keyring and bearer-token
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants