fix: test

go-rod · Jun 13, 2024 · fc41d1e · fc41d1e
1 parent 8ffcc0f
commit fc41d1e
Show file tree

Hide file tree

Showing 5 changed files with 26 additions and 8 deletions.
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
@@ -28,12 +28,12 @@ jobs:
         env:
           GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         with:
           name: review-fonts-docker
           path: tmp/fonts.pdf
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: ${{ always() }}
         with:
           name: cdp-log-docker

diff --git a/.github/workflows/test-linux.yml b/.github/workflows/test-linux.yml
@@ -23,11 +23,11 @@ jobs:
 
       - run: go generate
 
-      - run: go run ./lib/utils/ci-test -race -coverprofile=coverage.out ./...
+      - run: go run ./lib/utils/ci-test -race -coverprofile=coverage.out . ./lib/utils ./lib/proto ./lib/cdp ./lib/defaults ./lib/devices ./lib/launcher ./lib/input
 
       - run: go run github.com/ysmood/got/cmd/check-cov@latest
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: ${{ always() }}
         with:
           name: cdp-log-linux

diff --git a/.github/workflows/test-other-platforms.yml b/.github/workflows/test-other-platforms.yml
@@ -20,7 +20,7 @@ jobs:
 
       - run: go run ./lib/utils/ci-test -timeout-each=2m
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: ${{ always() }}
         with:
           name: cdp-log-macos
@@ -38,7 +38,7 @@ jobs:
 
       - run: go run ./lib/utils/ci-test -timeout-each=2m
 
-      - uses: actions/upload-artifact@v2
+      - uses: actions/upload-artifact@v4
         if: ${{ always() }}
         with:
           name: cdp-log-windows

diff --git a/lib/cdp/websocket_test.go b/lib/cdp/websocket_test.go
@@ -22,12 +22,14 @@ func TestWebSocketLargePayload(t *testing.T) {
 	ctx := g.Context()
 	client, id := newPage(ctx, g)
 
+	const size = 2 * 1024 * 1024
+
 	res, err := client.Call(ctx, id, "Runtime.evaluate", map[string]interface{}{
-		"expression":    fmt.Sprintf(`"%s"`, strings.Repeat("a", 2*1024*1024)),
+		"expression":    fmt.Sprintf(`"%s"`, strings.Repeat("a", size)),
 		"returnByValue": true,
 	})
 	g.E(err)
-	g.Gt(res, 2*1024*1024) // 2MB
+	g.Gt(len(res), size) // 2MB
 }
 
 func ConcurrentCall(t *testing.T) {

diff --git a/lib/utils/utils_test.go b/lib/utils/utils_test.go
@@ -7,6 +7,7 @@ import (
 	"image"
 	"image/jpeg"
 	"image/png"
+	"os/exec"
 	"path/filepath"
 	"testing"
 	"time"
@@ -17,6 +18,10 @@ import (
 
 var setup = got.Setup(nil)
 
+func TestNoop(_ *testing.T) {
+	utils.Noop()
+}
+
 func TestTestLog(t *testing.T) {
 	g := setup(t)
 
@@ -252,3 +257,14 @@ func TestCropImage(t *testing.T) {
 	g.E(jpeg.Encode(bin, img, &jpeg.Options{Quality: 80}))
 	g.E(utils.CropImage(bin.Bytes(), 0, 10, 10, 30, 30))
 }
+
+func TestUseNode(t *testing.T) {
+	g := setup(t)
+
+	utils.UseNode(false)
+
+	p, err := exec.LookPath("npx")
+	g.E(err)
+
+	g.Has(p, "v20")
+}