SetHeader should replace entries with the same key #1134
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
SetHeader
only appends the key-value pair to the end of headers list. The nameSetHeader
is therefore misleading.Adding header to the end sometimes won't have the same effect as replacing the header. For example, if the original response has these headers:
And after the following operations:
The browser will complain about:
The 'Access-Control-Allow-Origin' header contains multiple values 'https://example.com, https://example.com', but only one is allowed.
This PR changes the behavior of
SetHeader
to replace the value of the header if it exists. If the header does not exist, it will be appended to the end of the headers list.Also, if one writes:
Only the last value will be kept.