Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move login.html into a login component #1017

Merged
merged 21 commits into from
Dec 9, 2024

Conversation

fmartingr
Copy link
Member

Changes

  • Removed separate login page and route, integrating login functionality into the main SPA
  • Modified login component to match original design using Vue directives
  • Updated state management for login/main view visibility using v-if/v-else-if
  • Removed server-side version injection, replacing with API-based version fetching
  • Fixed logout functionality to show login form without page redirect

Technical Details

  1. Removed /login route from internal/http/routes/frontend.go
  2. Updated login component template in internal/view/assets/js/component/login.js:
  3. Modified internal/view/index.html:
    • Updated login state management
    • Improved logout function to maintain SPA behavior

@fmartingr fmartingr self-assigned this Dec 8, 2024
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.66%. Comparing base (617f5dd) to head (234bf1b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1017      +/-   ##
==========================================
- Coverage   34.74%   34.66%   -0.08%     
==========================================
  Files          61       61              
  Lines        5322     5316       -6     
==========================================
- Hits         1849     1843       -6     
  Misses       3249     3249              
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmartingr fmartingr added this to the 1.8.0 milestone Dec 8, 2024
@fmartingr fmartingr merged commit fb51755 into master Dec 9, 2024
17 checks passed
@fmartingr fmartingr deleted the refactor/login-component branch December 9, 2024 09:51
@fmartingr fmartingr modified the milestones: 1.8.0, 1.7.2 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant