feat: fixes to webroot feature and improvements to development using it #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: Update nginx configuration to resolve 502 gateway error fix: Update SHIORI_WEBROOT to SHIORI_HTTP_ROOT_PATH in docker-compose feat: Add debug log level flag to shiori service refactor: Update docker-compose with simplified command and log configuration fix: Change nginx port mapping from 80 to 8081 feat: Add volume for Go module cache in docker-compose style: Add type attribute to script tags in index.html feat: Update import statements to use RootPath variable in index.html
fmartingr
force-pushed
the
fix/webroot-dev
branch
from
cc5eacb to
a0fca6a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
+ Coverage 34.35% 34.46% +0.10%
==========================================
Files 61 61
Lines 5399 5412 +13
==========================================
+ Hits 1855 1865 +10
- Misses 3320 3323 +3
Partials 224 224 ☔ View full report in Codecov by Sentry. |
fmartingr
force-pushed
the
fix/webroot-dev
branch
from
51941ed to
c8febb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some issues regarding the usage of the
RootPathconfiguration, including validation of the attribute requiring a slash at the end to avoid issues in configurations.Also, added a
nginxservice to the development compose file to locally test this feature.