🐛 Fix gc artifact for multi-arch manifest (#336)

gc the multi-arch manifest need twice gc, first delete the manifest index,
second delete the reference manifest

pkg/daemon/gc/gc_artifact.go

@@ -226,12 +226,15 @@ func (g gcArtifact) deleteArtifactCheck() {
 				continue
 			}
 			// 3. check manifest index associate with this artifact
-			err = artifactService.IsArtifactAssociatedWithArtifact(g.ctx, task.Artifact.ID)
-			if err != nil && !errors.Is(err, gorm.ErrRecordNotFound) {
-				log.Error().Err(err).Int64("repositoryID", task.Artifact.RepositoryID).Int64("artifactID", task.Artifact.ID).Msg("Get manifest associated with manifest index failed")
-			}
-			if err == nil {
-				continue
+			if !(task.Artifact.ContentType == "application/vnd.docker.distribution.manifest.list.v2+json" ||
+				task.Artifact.ContentType == "application/vnd.oci.image.index.v1+json") { // skip this check if artifact is manifest index
+				err = artifactService.IsArtifactAssociatedWithArtifact(g.ctx, task.Artifact.ID)
+				if err != nil && !errors.Is(err, gorm.ErrRecordNotFound) {
+					log.Error().Err(err).Int64("repositoryID", task.Artifact.RepositoryID).Int64("artifactID", task.Artifact.ID).Msg("Get manifest associated with manifest index failed")
+				}
+				if err == nil {
+					continue
+				}
 			}
 			// 4. delete the artifact that referrer to this artifact
 			delArtifacts, err := artifactService.GetReferrers(g.ctx, task.Artifact.RepositoryID, task.Artifact.Digest, nil)

pkg/dal/dao/artifact.go

@@ -121,10 +121,10 @@ func (s *artifactService) Create(ctx context.Context, artifact *models.Artifact)
 // FindWithLastPull ...
 func (s *artifactService) FindWithLastPull(ctx context.Context, repositoryID int64, before int64, limit, last int64) ([]*models.Artifact, error) {
 	return s.tx.Artifact.WithContext(ctx).
+		Where(s.tx.Artifact.ID.Gt(last), s.tx.Artifact.RepositoryID.Eq(repositoryID)).
 		Where(s.tx.Artifact.LastPull.Lt(before)).
 		Or(s.tx.Artifact.LastPull.IsNull(), s.tx.Artifact.UpdatedAt.Lt(before)).
-		Where(s.tx.Artifact.ID.Gt(last), s.tx.Artifact.RepositoryID.Eq(repositoryID)).
-		Limit(int(limit)).Find()
+		Limit(int(limit)).Order(s.tx.Artifact.ID).Find()
 }
 
 // FindAssociateWithTag ...

pkg/dal/dao/blob.go

@@ -88,7 +88,7 @@ func (s *blobService) FindWithLastPull(ctx context.Context, before int64, last,
 		Where(s.tx.Blob.ID.Gt(last)).
 		Where(s.tx.Blob.LastPull.Lt(before)).
 		Or(s.tx.Blob.LastPull.IsNull(), s.tx.Blob.UpdatedAt.Lt(before)).
-		Find()
+		Order(s.tx.Blob.ID).Find()
 }
 
 // FindAssociateWithArtifact ...

pkg/dal/models/artifact.go

@@ -71,7 +71,7 @@ type ArtifactSizeByNamespaceOrRepository interface {
 
 // ArtifactAssociated ...
 type ArtifactAssociated interface {
-	// SELECT COUNT(artifact_id) as count FROM artifact_artifacts LEFT JOIN artifacts ON artifacts.id = artifact_artifacts.artifact_index_id WHERE artifacts.deleted_at = 0 AND artifact_index_id=@artifactID
+	// SELECT COUNT(artifact_id) as count FROM artifact_artifacts LEFT JOIN artifacts ON artifacts.id = artifact_artifacts.artifact_id WHERE artifacts.deleted_at = 0 AND artifact_index_id=@artifactID
 	ArtifactAssociated(artifactID int64) (gen.M, error)
 }