Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request updates two simple parts of the deployment.yaml template to support this chart:
list
value get concatenated into a CSV string as such:{{- $urls = printf "%s%s %s," $urls $model.url ($model.basicAuth | default "") }}
. This would cause errors as it would leave a trailing comma at the end of the CSV string and cause the url to be invalid. I fix this by adding a template function to trim the suffix of the string from any commas and then trimming whitespace.If I have misunderstood any parts of how to use this chart and appropriately set values, please feel free to respond and reject this Pull Request. But this was the only way I was able to get my helm chart to work.