Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/update model url templating #52

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amsuggs37
Copy link

This Pull Request updates two simple parts of the deployment.yaml template to support this chart:

  1. The urls in the list value get concatenated into a CSV string as such: {{- $urls = printf "%s%s %s," $urls $model.url ($model.basicAuth | default "") }}. This would cause errors as it would leave a trailing comma at the end of the CSV string and cause the url to be invalid. I fix this by adding a template function to trim the suffix of the string from any commas and then trimming whitespace.
  2. The regex to validate the url did not consider underscores as an option in the regex matching. Consider the following file uri in the goskynet/model-gallery (https://github.com/go-skynet/model-gallery/blob/main/mixtral-Q6.yaml#L42). This change will allow underscores as valid urls moving forward.

If I have misunderstood any parts of how to use this chart and appropriately set values, please feel free to respond and reject this Pull Request. But this was the only way I was able to get my helm chart to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant