Merge pull request #13 from CommanderStorm/ci-warnings

Changed from `actions-rs` to more maintained alternatives
goToMain · Aug 18, 2024 · cd9c3ae · cd9c3ae
2 parents e1b435c + f6e623e
commit cd9c3ae
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 14 deletions.
diff --git a/.github/workflows/build-ci.yml b/.github/workflows/build-ci.yml
@@ -21,14 +21,11 @@ jobs:
         with:
           submodules: recursive
       - name: Setup rust
-        uses: actions-rs/toolchain@v1
+        uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
         with:
           toolchain: stable
           components: rustfmt, clippy
-      - name: Cargo check
-        uses: actions-rs/cargo@v1
-        with:
-          command: check
+      - run: cargo check
   test:
     runs-on: ubuntu-latest
     steps:
@@ -37,10 +34,8 @@ jobs:
         with:
           submodules: recursive
       - name: Setup rust
-        uses: actions-rs/toolchain@v1
+        uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
         with:
           toolchain: stable
       - name: Cargo test
-        uses: actions-rs/cargo@v1
-        with:
-          command: test
+        run: cargo test
diff --git a/.github/workflows/publish-libosdp-sys.yml b/.github/workflows/publish-libosdp-sys.yml
@@ -25,7 +25,7 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: recursive
-    - uses: actions-rs/toolchain@v1
+    - uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
       with:
         toolchain: stable
         override: true
@@ -39,7 +39,7 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: recursive
-    - uses: actions-rs/toolchain@v1
+    - uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
       with:
         toolchain: stable
         override: true

diff --git a/.github/workflows/publish-libosdp.yml b/.github/workflows/publish-libosdp.yml
@@ -25,7 +25,7 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: recursive
-    - uses: actions-rs/toolchain@v1
+    - uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
       with:
         toolchain: stable
         override: true
@@ -39,7 +39,7 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: recursive
-    - uses: actions-rs/toolchain@v1
+    - uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
       with:
         toolchain: stable
         override: true

diff --git a/.github/workflows/publish-osdpctl.yml b/.github/workflows/publish-osdpctl.yml
@@ -21,7 +21,7 @@ jobs:
     - uses: actions/checkout@v3
       with:
         submodules: recursive
-    - uses: actions-rs/toolchain@v1
+    - uses: actions-rust-lang/setup-rust-toolchain@v1.9.0
       with:
         toolchain: stable
         override: true

diff --git a/libosdp/tests/common/device.rs b/libosdp/tests/common/device.rs
@@ -16,6 +16,7 @@ type Result<T> = core::result::Result<T, libosdp::OsdpError>;
 
 pub struct CpDevice {
     dev: Arc<Mutex<ControlPanel>>,
+    #[allow(unused)] // false positive, it is used!
     pub receiver: Receiver<(i32, OsdpEvent)>,
 }
 

diff --git a/libosdp/tests/common/threadbus.rs b/libosdp/tests/common/threadbus.rs
@@ -20,6 +20,7 @@ pub struct ThreadBus {
     recv: Mutex<BroadcastReceiver<Vec<u8>>>,
 }
 
+#[allow(unused)] // false positive, it is used!
 fn str_to_channel_id(key: &str) -> i32 {
     let mut hasher = DefaultHasher::new();
     key.hash(&mut hasher);
@@ -29,6 +30,7 @@ fn str_to_channel_id(key: &str) -> i32 {
 }
 
 impl ThreadBus {
+    #[allow(unused)] // false positive, it is used!
     pub fn new(name: &str) -> Self {
         let (send, recv) = multiqueue::broadcast_queue(4);
         Self {