Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all fields of
PdInfo
are private.The current way, to get access to them is to
as_struct
an instance and then compare the c-fields. This is somewhat cumbersome to do and not quite ergonomic.=> I think making these fields
pub
is likely betterAs an alternative, (if you'd like that more) I can make these fields into methods.
Another alternative would be to just publish parts of the fields, but that is something that I would want your oppinion on ^^