Add python 3.12 support #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbailey-godaddy
force-pushed
the
bugfix/version-bumps
branch
from
c468438
to
0ec146f
Compare
* Add support for python 3.12; * This necessitated some library updates, so update basically everything to the extent that python versions 3.8-3.12 remain supported; * Add python 3.12 to GitHub workflows; * Adjust `shutil.rmtree()` calls; in python 3.12, the `onerror` argument becomes changes type and becomes deprecated -- luckily, we don't use it, so it's easy to paper over; * Minor formatting changes to placate the latest version of black; * Add some test annotations to `test_util.py` because pylint now is smart enough to think some code is unreachable (although it is because of the testing context); * "Fix" one test in `test_scan_local_repo.py` that fails only with python 3.12 because click's CliRunner directory context appears to come up with a bizarrely wrong path name that propagates into error messages - relax the test to ignore the reported pathname. This should be enough to silence all of the outstanding dependabot PRs.
rbailey-godaddy
force-pushed
the
bugfix/version-bumps
branch
from
0ec146f
to
b619b0b
Compare
emayuri-godaddy
approved these changes
Jul 25, 2024
sushantmimani
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
What's new?
shutil.rmtree()calls; in python 3.12, theonerrorargument becomes changes type and becomes deprecated -- luckily, we don't use it, so it's easy to paper over;test_util.pybecause pylint now is smart enough to think some code is unreachable (although it is because of the testing context);test_scan_local_repo.pythat fails only with python 3.12 because click's CliRunner directory context appears to come up with a bizarrely wrong path name that propagates into error messages - relax the test to ignore the reported pathname.This should be enough to silence all of the outstanding dependabot PRs.